Resolve proc override paths in var values #1981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out-of-phaze
suggested changes
Sep 21, 2024
| /atom/movable/proc/foo() | ||
| return | ||
|
|
||
| /datum/var/bar = /atom/movable/foo |
There was a problem hiding this comment.
this errors in DM, it's invalid (tries to find a type rather than a proc)
in 515 and later the proper way to call the latest override (lateral or descended) is via call(nameof(/atom/movable/proc/foo))() (or call(nameof(/atom/movable.proc/foo))(), i don't know why that one is sometimes used? i think it's just a legacy thing)
There was a problem hiding this comment.
Repeating what I said on discord a while back (to keep any PR observers informed), this does work if it's a proc override. My mistake was not erroring when there's no proc override declared.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets bay compiling when some of my other PRs are also merged.
Also changes procpaths with
/proc/elements to point at the original declaration, not lateral overrides. In this case a new pragma is emitted if lateral overrides exist.